[Moves] Many secondary effects fail to proc if the move dealt 0 damage

[Haneroze]

Hello~

 

When a low level pokemon faces a high level pokemon with type resistances, it is possible for a move to hit and still deal 0 damage. If that happens, Status effect and stat drops will never proc.

 

Prerequisites (for testing):

- Two players.

- Player A has a Pokemon under level 10 that knows Mud Slap.

- Player B has a level 100 Parasect.

 

Steps to Reproduce:

1. Both players fight each other.

2. Player A uses Mud Slap against Player B's Parasect.

 

Current Result:

Parasect takes 0 damage and its accuracy is not dropped.

 

Expected Result:

Parasect takes 1 damage and its accuracy is dropped by one stage.

 

Notes:

- In the original Pokemon games, it is impossible to take 0 damage. In PRO, it is possible only for resisted attacks. Double resistance makes it significantly easier to occur.

- This issue has been confirmed to occur with Twineedle, Smog and Mud Slap.

- Astonish successfully flinches even when dealing 0 damage, leading to believe that this issue only occurs for Status effects and Stat drops secondary effects.