Jump to content

NQR BOT ( Not Quite Reborn )


Bloodemperor

Recommended Posts

d50a5a07d3a3aa933b8763c53a4e4ef7.png?size=256

ABOUT

NQR aka Not Quite Reborn is a discord bot.

The bot was made because Reborn bot cannot be added to new servers for the time being but later we decided to create it something beyond such that it wont be irrelevant if reborn can be added to new servers again but since we got busy IRL we stopped working on the bot.

SERVER INVITE LINK

https://discord.com/api/oauth2/authorize?client_id=810237383832240162&permissions=139855264832&scope=bot applications.commands

NOTES

I do not Maintain the bot anymore.

SOURCES

Spawns, Items = https://pokemonrevolution.net/spawns/
Smogon = https://github.com/pokemondev/smogon-stats-discord
Dex = https://github.com/Purukitto/pokemon-data.json
Movesets = https://github.com/Deskbot/Pokemon-Learnsets
Digspots = https://prowiki.info/index.php?title=Diggable_Patches

Headbutt = https://prowiki.info/index.php?title=Special:GetData/HeadbuttSpawnData

Excavations = https://pokemonrevolution.net/forum/topic/112424-hoenn-excavation-sites-guide/

Mostused = https://pokemonrevolution.net/forum/topic/142666-most-used-pokemon/

Info = https://github.com/Touched/pokedex-data/tree/master/tables and https://pokemonrevolution.net/forum/forum/16-game-data/

TM,HM and MoveTutors Data = https://pokemonrevolution.net/forum/topic/26744-tms-move-tutors/ and https://pokemonrevolution.net/forum/topic/165223-content-update-logs

Evspots, Repel = Reborn Bot

Notcoded = https://pokemonrevolution.net/forum/topic/28126-list-of-broken-moves-abilities-in-pro/

image.png.2427238aa6f2c98b34e1b9512d9ae7a5.png

 

Edited by Bloodemperor
Changed bot link
  • Like 7
Link to comment
Share on other sites

As a contributor, I am pleased to see more contributions done on PRO, especially on this type of field.

And hope you'll have a good time while doing so and learn as much as you can.

 

Constructive Critism from a fellow Discord Bot Developer:

Now, as a Discord Bot Developer, and soul owner and developer of Tsumiki Discord bot.

It has 120+ commands, advanced systems like Mention system, Pagination system etc and being in over 2000 servers.

So, by all that I can ensure you that my opinion is constructive.

 

I want to give my personal opinion on this from a developer's perpsective.

I will be very strict, so hope you can enjoy some consctructive criticism from someone experienced in this field, else turn back now.

 

You lack responses to every command, if no parameters are given.

I.e using ^s without any route or map name parameters, it returns nothing.

This is an especially bad behavior, and its pretty common knowledge for any Discord bot developer to know.

 

You have no whitespace remover for prefix, in case someone accidentally types "^ help" or related.

Anything that helps the user overcome their own mistakes and still get a response, is all the better for the bot in the long haul.

Its also small features like this, that users would initially come to love.

 

This is more or less just copy-pasted formatting from Reborn

I.e everything looks the same as Reborn in terms of format.

It might as well have been done by myself in half an hour and called it a day. Seriously.


You might call it "NQR - Not Quite Reborn", but its an identical replica of Reborn.

But you've edited the footers in the embedded messages and added some mod commands.

As a bot developer, I feel like you've stepped on someone's foot and continued to walk forward like nothing happened.

 

If its not hosted on a server with a uptime of 24/7, it might as well be hosted by someone's computer.

Nowadays its very easy to find a free 24/7 hosting solution, and its even easier to set it up with a Discord bot.

 

Outdated content - A developer's worst nightmare scenario.

Having outdated content (i.e spawns from pre-valentine) would impact the bot's overall preformence.

People would certainly be given the wrong information and believe the bot is "outdated". Since much has changed since the last release in terms of spawns.

And with new locations, comes new spawn locations. Which also heavily impacts outdated content and the bot's preformence.

Even the smallest of details would either make someone stay and use the bot or instantly decide to drop it.

 

Seems like you're using SM instead of XY for Smogon.

Idk why you've decided to go for that, since Z-moves are not currently in the game.

And I believe that XY is still the most relevant to PRO's current game situation, with mega Pokemon being a thing.

 

But, I will say that I am impressed, even if its still somewhat a replica and something that could be easily done by any Discord Bot Developer.

Hope to see some good changes with this bot in the near future.

Edited by Electrocute4u
  • Like 1
  • Haha 2

 Contributor 

"In order to be irreplaceable, one must always be different"

Forum post | Bulba - Discord Bot | Website

 

MyAnimeList Profile and Stats

Discord Status

spacer.png

Link to comment
Share on other sites

Hey @Electrocute4u, I am thankful that you took out time to write such an amazing response.

First of all I would like to clear out that I'm no experienced developer and I just learnt python about a year ago but never really had any project to work on so there are many newbie mistakes I made which I'm happy you pointed. I started working on NQR to learn how a discord bot works.

4 hours ago, Electrocute4u said:

You lack responses to every command, if no parameters are given.

I was already thinking of fixing this but since I was busy in real life for the past few days so I haven't been able to do anything.

I actually learnt how to read messages from discord by the command "if message.content.startswith()" and not the bot.command() so I might have to change the code abit for that too.

 

5 hours ago, Electrocute4u said:

You have no whitespace remover for prefix, in case someone accidentally types "^ help" or related.

I will find a way on how to make this work.

 

5 hours ago, Electrocute4u said:

This is more or less just copy-pasted formatting from Reborn

well I am guilty of doing that but I feel the original reborn does a great job of formatting.

 

5 hours ago, Electrocute4u said:

You might call it "NQR - Not Quite Reborn", but its an identical replica of Reborn.

I just named it that for no reason xD but there are some more commands that I will be working on such as ^digspots and ^excavation which tells where are the sites,requirements,items and spawns in them.

 

5 hours ago, Electrocute4u said:

If its not hosted on a server with a uptime of 24/7, it might as well be hosted by someone's computer.

The bot is hosted on a free server with a uptime of 24/7 but there are sometimes when it needs to update libraries then it needs the developer to manually run the code on the server again for it to start working. I have seen such a scenario only twice until now.

 

5 hours ago, Electrocute4u said:

Outdated content - A developer's worst nightmare scenario.

All the spawn content is taken from PRO's spawn dump for now but excuse me for being lazy and not fixing the valentine spawns xD I thought since valentine is about to come to an end soon I should just update it when easter event will be live in the game.

 

5 hours ago, Electrocute4u said:

Seems like you're using SM instead of XY for Smogon.

I'm actually using the gen 7 for Smogon and yes the Z move hurt alot I will change it when I have the time to work on the bot next time

 

In the end I would like to thank you again for pointing out my mistake and I hope you will point out more in the future when I make more commands for the bot

  • Like 1
Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...